Skip to content

Conversation

@dfajmon
Copy link

@dfajmon dfajmon commented Nov 5, 2025

andyzhangx and others added 30 commits May 12, 2025 03:19
Bumps build-image/debian-base from bookworm-v1.0.4 to bookworm-v1.0.5.

---
updated-dependencies:
- dependency-name: build-image/debian-base
  dependency-version: bookworm-v1.0.5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…docker/cmd/smbplugin/build-image/debian-base-bookworm-v1.0.5

chore(deps): bump build-image/debian-base from bookworm-v1.0.4 to bookworm-v1.0.5 in /cmd/smbplugin
…-1.14.0

chore: upgrade csi-resizer to v1.14.0
If the password to SMB-server contained special characters (e.g. "foo,bar"), the mount failed. Now, when the password is passed to mount via "credentials=filename" option, then mount succeeds.
…mount-option

fix: enable to use secrets with special characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…github_actions/actions/checkout-5

chore(deps): bump actions/checkout from 4 to 5
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…github_actions/actions/setup-go-6

chore(deps): bump actions/setup-go from 5 to 6
Bumps build-image/debian-base from bookworm-v1.0.5 to bookworm-v1.0.6.

---
updated-dependencies:
- dependency-name: build-image/debian-base
  dependency-version: bookworm-v1.0.6
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…docker/cmd/smbplugin/build-image/debian-base-bookworm-v1.0.6

chore(deps): bump build-image/debian-base from bookworm-v1.0.5 to bookworm-v1.0.6 in /cmd/smbplugin
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2025

@dfajmon: This pull request references STOR-2585 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Issue link
https://issues.redhat.com/browse/STOR-2585

Diff to upstream v1.19.1
kubernetes-csi/csi-driver-smb@v1.19.1...dfajmon:rebase-v1.19.1

Notes for reviewers

Changes Summary

Full changelog

https://github.comkubernetes-csi/csi-driver-smb/releases/tag/v1.19.1

Last rebase

#26

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gnufied and jsafrane November 5, 2025 11:15
@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@jsafrane
Copy link

Please squash all the carry commits into UPSTREAM: <carry>: Add OpenShift files

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2025

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Phaow
Copy link

Phaow commented Nov 11, 2025

/unassign @duanwei33 @chao007 @radeore

@Phaow
Copy link

Phaow commented Nov 13, 2025

/verified by CI.
The new rebase do not have user facing changes, the only one kubernetes-csi#961 we already cherry-pick and verify it in previous releases. So regression test should be enough, I manually build the driver/operator/bundle/index images with the rebase PR and launch regression tests all passed.

sh-5.1# ./bin/smbplugin -ver
Build Date: "2025-11-12T07:57:40Z"
Compiler: gc
Driver Name: smb.csi.k8s.io
Driver Version: v1.19.1
Git Commit: 75e6053f4d4297d922141f0213c75f5582f47af9
Go Version: go1.24.6 (Red Hat 1.24.6-1.el9_6) X:strictfipsruntime
Platform: linux/amd64

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 13, 2025
@openshift-ci-robot
Copy link

@Phaow: This PR has been marked as verified by CI..

In response to this:

/verified by CI.
The new rebase do not have user facing changes, the only one kubernetes-csi#961 we already cherry-pick and verify it in previous releases. So regression test should be enough, I manually build the driver/operator/bundle/index images with the rebase PR and launch regression tests all passed.

sh-5.1# ./bin/smbplugin -ver
Build Date: "2025-11-12T07:57:40Z"
Compiler: gc
Driver Name: smb.csi.k8s.io
Driver Version: v1.19.1
Git Commit: 75e6053f4d4297d922141f0213c75f5582f47af9
Go Version: go1.24.6 (Red Hat 1.24.6-1.el9_6) X:strictfipsruntime
Platform: linux/amd64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e0e3bf5 into openshift:master Nov 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants